[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#37853] [PATCH] gnu: Add ddcci-driver-linux.
From: |
Mathieu Othacehe |
Subject: |
[bug#37853] [PATCH] gnu: Add ddcci-driver-linux. |
Date: |
Tue, 22 Oct 2019 11:42:58 +0200 |
User-agent: |
mu4e 1.2.0; emacs 26.3 |
Hello Brice,
> + (url
> "https://gitlab.com/ddcci-driver-linux/ddcci-driver-linux.git")
This line is too long. You can add a line break after "uri" so that it
fits under 78 columns.
> + (replace 'build
> + (lambda* (#:key inputs #:allow-other-keys)
> + (for-each (lambda (module)
> + (invoke "make" "-C"
> + (string-append (assoc-ref inputs
> "linux-module-builder")
> + "/lib/modules/build")
> + (string-append "M=" (getcwd) "/" module)))
> + (list "ddcci" "ddcci-backlight"))
It is a bit sad that we have to replicate 'build and 'install phases
because of those two subfolders. However, I can't see an easy way to
overcome this. Anyone?
> +a character device for each DDC/CI monitors in @file{/dev/bus/ddcci/[I²C bus
> number]}.
> +ddcci-backlight allow the control of the backlight level or luminance
> property when supported
As reported by guix lint, this line is too long. Also make sure that the
description starts by a full sentence, for instance: "This package
provides a pair of ...".
Can you send an updated patch?
Thanks,
Mathieu