[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#37857] [PATCH] guix: svn: Allow dropping externals
From: |
Ludovic Courtès |
Subject: |
[bug#37857] [PATCH] guix: svn: Allow dropping externals |
Date: |
Tue, 22 Oct 2019 18:10:59 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi Julien,
Julien Lepiller <address@hidden> skribis:
>>From 0ac412a3c912b2fe7ebd05d178120db50d47184e Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <address@hidden>
> Date: Mon, 21 Oct 2019 21:48:31 +0200
> Subject: [PATCH] guix: svn: Allow dropping externals.
>
> * guix/build/svn.scm (svn-fetch): Allow to ignore externals.
> * guix/svn-download.scm (svn-reference, svn-multi-reference): Add
> fetch-externals? field.
Nice.
For consistency with git-download.scm & co., what about calling the
parameter and the field ‘recursive?’ rather than ‘fetch-externals?’?
> (define-record-type* <svn-reference>
> svn-reference make-svn-reference
> svn-reference?
> - (url svn-reference-url) ; string
> - (revision svn-reference-revision) ; number
> - (user-name svn-reference-user-name (default #f))
> - (password svn-reference-password (default #f)))
> + (url svn-reference-url) ; string
> + (revision svn-reference-revision) ; number
> + (fetch-externals? svn-reference-fetch-externals? (default #t))
Do you know of packages that rely on externals?
It’d be great to eventually default to #f, but for that we’d need to
check every package that uses ‘svn-fetch’ (notably all the TeX Live
packages.)
Thanks,
Ludo’.