[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#36630] [PATCH] use two threads to build man-pages and secure output
From: |
Arne Babenhauserheide |
Subject: |
[bug#36630] [PATCH] use two threads to build man-pages and secure output msgs with mutex |
Date: |
Wed, 23 Oct 2019 21:59:18 +0200 |
---
guix/profiles.scm | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/guix/profiles.scm b/guix/profiles.scm
index a0ae9a4c7e..9d2133df2d 100644
--- a/guix/profiles.scm
+++ b/guix/profiles.scm
@@ -1315,11 +1315,18 @@ the entries in MANIFEST."
(ice-9 threads)
(srfi srfi-1)
(srfi srfi-19))
+ ;; ensure conflict free user-output
+ (define status-output-mutex (make-mutex))
+
+ (define (status-message msg)
+ (lock-mutex status-output-mutex)
+ (display msg)
+ (unlock-mutex status-output-mutex))
(define (compute-entry directory count total)
- (format #t "\r[~3d/~3d] building list of \
+ (status-message (format #f "\r[~3d/~3d] building
list of \
man-db entries..."
- count total)
+ count total))
(force-output)
(let ((man (string-append directory
"/share/man")))
@@ -1332,7 +1339,9 @@ man-db entries..."
;; decompression), so report progress as we traverse INPUTS.
(let* ((inputs '#$(manifest-inputs manifest))
(total (length inputs)))
- (apply append (par-map compute-entry
+ ;; experimenting shows that two threads suffice to remove most
+ ;; waiting
+ (apply append (n-par-map 2 compute-entry
inputs
(iota total 1)
(make-list total total)))))
--
2.23.0
- [bug#36630] [PATCH] use two threads to build man-pages and secure output msgs with mutex,
Arne Babenhauserheide <=