[bug#38325] [PATCH 1/2] gnu: Add tdlib.

[Brett Gilio]

Ludovic Courtès <address@hidden> writes:

> Hello!
>
> Brett Gilio <address@hidden> skribis:
>
>>>From c47ed88ed3945fd7dbdee2b7e507ec512dd799be Mon Sep 17 00:00:00 2001
>> From: Brett Gilio <address@hidden>
>> Date: Fri, 22 Nov 2019 12:53:32 -0600
>> Subject: [PATCH 1/2] gnu: Add tdlib.
>>
>> * gnu/packages/messaging.scm (tdlib): New variable.
>
> [...]
>
>> +      (build-system cmake-build-system)
>> +      (arguments
>> +       `(#:tests? #f))
>
> Apparently there are tests.  Could you look into enabling them?
>
> If some of them fail, we should investigate.
>
> Last thing: please address ‘guix lint’ warnings, I think there’s a
> couple of them.  :-)
>
> Thank you,
> Ludo’.

Hey Ludo,

I have fixed the linting issue. The reason why I have disabled tests is
because the test cases require internet connection.

[ 1][t 0][1574796396.378631592][mtproto.cpp:64][!GetHostByNameActor]    7 
"web.telegram.org" [Error : 0 : Failed to resolve host: Name or service not 
known]
[ 1][t 0][1574796396.378687382][mtproto.cpp:64][!GetHostByNameActor]    8 
"web.telegram.org" [Error : 0 : Failed to resolve host: Name or service not 
known]
[ 1][t 0][1574796396.378721476][mtproto.cpp:64][!GetHostByNameActor]    9 
"web.telegram.org." [Error : 0 : Failed to resolve host: Name or service not 
known]
[ 1][t 0][1574796396.378756762][mtproto.cpp:64][!GetHostByNameActor]    10 
"web.telegram.org." [Error : 0 : Failed to resolve host: Name or service not 
known]
[ 1][t 0][1574796396.378843307][mtproto.cpp:64][!GetHostByNameActor]    11 
"москва.рф" [Error : 0 : Failed to resolve host: Name or service not known]
[ 1][t 0][1574796396.379258633][mtproto.cpp:64][!GetHostByNameActor]    37 
"web.telegram.org" [Error : 0 : Failed to resolve host: Name or service not 
known]
[ 1][t 0][1574796396.379312277][mtproto.cpp:64][!GetHostByNameActor]    38 
"web.telegram.org" [Error : 0 : Failed to resolve host: Name or service not 
known]
[ 1][t 0][1574796396.379376888][mtproto.cpp:64][!GetHostByNameActor]    39 
"web.telegram.org." [Error : 0 : Failed to resolve host: Name or service not 
known]
[ 1][t 0][1574796396.379430532][mtproto.cpp:64][!GetHostByNameActor]    40 
"web.telegram.org." [Error : 0 : Failed to resolve host: Name or service not 
known]
[ 1][t 0][1574796396.379479170][mtproto.cpp:64][!GetHostByNameActor]    41 
"москва.рф" [Error : 0 : Failed to resolve host: Name or service not known]
[ 1][t 0][1574796396.381045103][mtproto.cpp:64][!GetHostByNameActor]    67 
"web.telegram.org" [Error : 0 : Failed to resolve host: Name or service not 
known]
[ 1][t 0][1574796396.381077766][mtproto.cpp:64][!GetHostByNameActor]    68 
"web.telegram.org" [Error : 0 : Failed to resolve host: Name or service not 
known]
[ 1][t 0][1574796396.381108761][mtproto.cpp:64][!GetHostByNameActor]    69 
"web.telegram.org." [Error : 0 : Failed to resolve host: Name or service not 
known]
[ 1][t 0][1574796396.381140471][mtproto.cpp:64][!GetHostByNameActor]    70 
"web.telegram.org." [Error : 0 : Failed to resolve host: Name or service not 
known]
[ 1][t 0][1574796396.381173134][mtproto.cpp:64][!GetHostByNameActor]    71 
"москва.рф" [Error : 0 : Failed to resolve host: Name or service not known]

I might be able to strip out those particular tests, but it would seem
to me that needing internet connection on a test case is likely not the
"Guix way" of doing this.

Wdyt?

Brett Gilio