[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#35866] [PATCH] gnu: Add qtwebengine.
From: |
mike . rosset |
Subject: |
[bug#35866] [PATCH] gnu: Add qtwebengine. |
Date: |
Wed, 01 Jan 2020 08:29:11 -0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hartmut Goebel <address@hidden> writes:
> Hi,
> in addtion to other remarks:
>
> Am 18.12.19 um 21:45 schrieb Mike Rosset
>
>
> + (uri
> + (string-append "https://download.qt.io/official_releases/qt/"
> + (substring version 0 4)
> + "/" version "/submodules/"
> + (string-append name "-everywhere-src-" version)
> + ".tar.xz"))
>
> Please use the same code and formatting as sued for qtsvg. This helps keeping
> the code consistent.
>
> + `(modify-phases ,phases
> + (replace 'configure
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + ;; Avoids potential race conditions
>
> I suggest to put this into *two* new phases: `patch-source` (or so)
> containing the substitute stuff, and `setup-configure` for setting the
> environment variables.
>
>
> + (substitute* "src/core/web_engine_library_info.cpp"
> +
> (("QLibraryInfo::location\\(QLibraryInfo::TranslationsPath\\)")
> + (format #f "QLatin1String(\"~a\")" (string-append
> (assoc-ref outputs "out") "/share/qt5/translations")))
> + (("QLibraryInfo::location\\(QLibraryInfo::DataPath\\)")
> + (format #f "QLatin1String(\"~a\")" (string-append
> (assoc-ref outputs "out") "/share/qt5"))))
>
> I suggest *not* using `format`, as we rarely use it in substitutes and you
> are using `string-append` anyway. I also suggest to define a variable `out`
> to be used here (same for `nss`, `udev` below) to avoid having `assic-ref`
> here, see [0] as an example. Then `format` might even be beneficial:
>
> + (format #f "QLatin1String(\"~a/share/qt5/translations\")"
> out)
>
> + (string-append "QLatin1String(\"" out
> "/share/qt5/translations\")")
>
> [0]
> <https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/qt.scm#n605>
I have made all these changes as requested they should be in 0004 of
series. I've re emailed the complete series. I believe there was an
issue mailing 003.
>
> + ;; Valid QT_BUILD_PARTS variables are:
> + ;; libs tools tests examples demos docs translations
> + (invoke "qmake" "QT_BUILD_PARTS = libs tools" "--"
> + "--webengine-printing-and-pdf=no"
> + "--webengine-ffmpeg=system"
> + "--webengine-icu=system"
> + "--webengine-pepper-plugins=no")))))
>
> Would setting `#:configure-flags` with "-DBUILD_TESTS=off" (see e.g. [1])
> work, too, instead of passing "QT_BUILD_PARTS"?
>
> [1]
> <https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/qt.scm#n2119>
It's possible that this might work. But I don't think it's worth the
effort. I kept this in line qtsvg hopefully I can switch the tests on at
one point. I have documented why the tests can not be run as of now.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [bug#35866] [PATCH] gnu: Add qtwebengine.,
mike . rosset <=