[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#39642] [PATCH 1/3] ui: Only display link in capable terminals.
From: |
zimoun |
Subject: |
[bug#39642] [PATCH 1/3] ui: Only display link in capable terminals. |
Date: |
Mon, 17 Feb 2020 17:05:45 +0100 |
Hi Pierre,
Thank you for looking at. :-)
On Mon, 17 Feb 2020 at 14:41, Pierre Neidhardt <address@hidden> wrote:
> ---
> guix/scripts/describe.scm | 16 ++++++++++++----
> guix/ui.scm | 2 +-
> 2 files changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/guix/scripts/describe.scm b/guix/scripts/describe.scm
> index f13f221da9..9a7bd52163 100644
> --- a/guix/scripts/describe.scm
> +++ b/guix/scripts/describe.scm
> @@ -201,7 +201,12 @@ way and displaying details about the channel's source
> code."
> (format #t (G_ " commit: ~a~%")
> (if (supports-hyperlinks?)
> (channel-commit-hyperlink channel commit)
> - commit))))
> + commit))
> + (when (not (supports-hyperlinks?)
> + )
Issue on the closing parenthesis ')'.
Indent?
> @@ -233,9 +238,12 @@ way and displaying details about the channel's source
> code."
>
> (define* (channel-commit-hyperlink channel
> #:optional
> - (commit (channel-commit channel)))
> + (commit (channel-commit channel))
> + (transformer hyperlink))
> "Return a hyperlink for COMMIT in CHANNEL, using COMMIT as the hyperlink's
> -text. The hyperlink links to a web view of COMMIT, when available."
> +text. The hyperlink links to a web view of COMMIT, when available.
> +TRANSFORMER is a procedure of 2 arguments, a URI and text, and returns a
I do not have tried with another 'transformer' than 'hyperlink' or
'identity'. :-)
Cheers,
simon