[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#39647] [PATCH] gnu: Add unoconv.
From: |
Jakub Kądziołka |
Subject: |
[bug#39647] [PATCH] gnu: Add unoconv. |
Date: |
Thu, 20 Feb 2020 21:47:28 +0100 |
Hi,
I tried to use the package in a `guix environment' and got:
~/guix% unoconv ~/Downloads/scheme-macro-phd.ps -o scheme-macro-phd.pdf
unoconv: format [jw4yj39s84jb4fkvqpsqwq-unoconv-0.9.0/bin/.unoconv-real] is not
known to unoconv.
I feel like this might be an issue with the packaging. Does it work for
you?
On Mon, Feb 17, 2020 at 07:25:09PM +0100, Tobias Geerinckx-Rice wrote:
> + (modify-phases %standard-phases
> + (add-after 'unpack 'patch-find_offices
I think that the convention is to replace underscores by dashes in names
like these.
> + ;; find_offices is a convoluted cross-platform treasure hunt.
> + ;; Keep things simple and return the correct paths immediately.
> + (lambda* (#:key inputs #:allow-other-keys)
> + (let* ((libreoffice (assoc-ref inputs "libreoffice")))
> + (substitute* "unoconv"
> + (("def find_offices\\(\\):" match)
> + (string-append
> + match "\n"
> + " ret = []\n"
> + " office = Office("
> + "'" libreoffice "/lib/libreoffice', "
> + "'" libreoffice "/lib/libreoffice/program', "
> + "'" libreoffice "/lib/libreoffice/program', "
> + "'" libreoffice "/lib/libreoffice/program/pyuno.so', "
> + "'" libreoffice "/bin/soffice', "
> + "sys.executable, "
> + "None)\n"
> + " ret.append(office)\n"
> + " return ret\n")))
> + #t))))))
Wouldn't it be simpler to do
return [Office(...)]
?
signature.asc
Description: PGP signature