[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#39698] [PATCH] file-systems: Set default value of the check? field
From: |
Ludovic Courtès |
Subject: |
[bug#39698] [PATCH] file-systems: Set default value of the check? field to #f for NFS |
Date: |
Sat, 22 Feb 2020 12:17:23 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi,
Maxim Cournoyer <address@hidden> skribis:
> --- a/gnu/system/file-systems.scm
> +++ b/gnu/system/file-systems.scm
> @@ -101,6 +101,8 @@
> (define-record-type* <file-system> %file-system
> make-file-system
> file-system?
> + this-file-system
> +
> (device file-system-device) ; string | <uuid> |
> <file-system-label>
> (mount-point file-system-mount-point) ; string
> (type file-system-type) ; string
> @@ -113,7 +115,10 @@
> (needed-for-boot? %file-system-needed-for-boot? ; Boolean
> (default #f))
> (check? file-system-check? ; Boolean
> - (default #t))
> + (thunked)
> + (default (not (string-prefix-ci?
> + (file-system-type this-file-system)
> + "nfs"))))
I’d rather avoid making ‘check?’ a thunked field (it adds a bit of
overhead and breaks ‘equal?’.)
Could we instead special-case NFS in (gnu build file-systems) such that
checking is a no-op?
Thanks,
Ludo’.