[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#39739] New: ac-geiser
From: |
Kyle Meyer |
Subject: |
[bug#39739] New: ac-geiser |
Date: |
Sat, 22 Feb 2020 18:01:10 +0000 |
Hi Jeremy,
Jeremy Korwin-Zmijowski <address@hidden> writes:
> Subject: [PATCH 1/1] gnu: Add emacs-ac-geiser.
>
> * gnu/packages/emacs-xyz.scm (emacs-ac-geiser): New variable
To follow this project's conventions, I think the leading spaces should
be dropped and a period added at the end.
> +(define-public emacs-ac-geiser
> + (package
> + (name "emacs-ac-geiser")
> + (version "0.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://stable.melpa.org/packages/ac-geiser-"
> + version
> + ".tar"))
Hmm, I see only one existing package definition that uses a
stable.melpa.org URL, and it looks like these URLs should be avoided for
mutability reasons:
https://lists.gnu.org/archive/html/guix-patches/2019-03/msg00367.html
Can you replace this with a git-fetch from GitHub?
> + (sha256
> + (base32
> + "17l5bpzpldzyazbpjg67f17x3n5q081xffx4jz7jblbk7bcybzrj"))))
> + (build-system emacs-build-system)
> + (propagated-inputs
> + `(("emacs-geiser" ,emacs-geiser)
> + ("emacs-auto-complete" ,emacs-auto-complete)))
> + (home-page "https://github.com/xiaohanyu/ac-geiser/")
> + (synopsis "Auto-complete backend for geiser")
> + (description
> + "Provides one auto-complete source for Scheme projects using geiser.
> +")
style nit: Please put this closing quote and parenthesis on the previous
line.
> + (license license:bsd-3)))
This does match what's in the LICENSE file, but the header in
ac-geiser.el claims that it's gpl3+. Perhaps it's worth asking upstream
for clarification.