[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than ab
From: |
Ludovic Courtès |
Subject: |
[bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold. |
Date: |
Sun, 23 Feb 2020 17:09:11 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi!
Pierre Neidhardt <address@hidden> skribis:
> See the original discussion:
>
> https://lists.gnu.org/archive/html/guix-devel/2020-02/msg00303.html
Oops, I’m lagging behind and had not seen it yet, sorry about that!
> Our users fall into 2 categories:
>
> - Those with a "small" store partition, say 25 GiB.
> - Those with a "big" store partition, say 1 TiB.
>
> If we use a relative threshold, users with a big partition will get
> a hint all the time. This may mislead newcomers into thinking that they
> should run "guix gc" while they still have 50 GiB of free space.
>
> If we use an absolute threshold, users with a small partition will get a
> hint all the time.
>
> In both cases, the hints becomes irrelevant if it's triggered for the
> wrong reason.
>
> The fix is to use both thresholds and to check against the lowest one.
>
> Does that make more sense?
It does, yes.
So back to the original patch… I think we should use ‘size->number’ for
the absolute threshold.
I’m also still mildly reluctant to the addition of
‘GUIX_DISK_SPACE_WARNING_ABSOLUTE’ (one more variable and a weird
name—“absolute warning”?). An option could be to allow
‘GUIX_DISK_SPACE_WARNING’ to optionally contain both thresholds. These
would be valid values:
1GiB;10%
15 ;15% relative, and default absolute
15% ;same
1G ;1G absolute, and default relative
Thus ‘%disk-space-warning’ would hold a pair.
Does that make sense?
Apologies for the misunderstanding!
Ludo’.
- [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold., Pierre Neidhardt, 2020/02/22
- [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold., Ludovic Courtès, 2020/02/22
- [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold., Pierre Neidhardt, 2020/02/22
- [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold., Ludovic Courtès, 2020/02/23
- [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold., Pierre Neidhardt, 2020/02/23
- [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold., Ludovic Courtès, 2020/02/23
- [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold., Pierre Neidhardt, 2020/02/23
- [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold.,
Ludovic Courtès <=
- [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold., Pierre Neidhardt, 2020/02/23
- [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold., Pierre Neidhardt, 2020/02/23
- [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold., Pierre Neidhardt, 2020/02/23
- [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold., Ludovic Courtès, 2020/02/24
- [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold., Pierre Neidhardt, 2020/02/24
- [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold., Pierre Neidhardt, 2020/02/24
- [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold., Ludovic Courtès, 2020/02/24
- [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold., Pierre Neidhardt, 2020/02/25
- [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold., Pierre Neidhardt, 2020/02/25
- [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold., Ludovic Courtès, 2020/02/27