[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#39754: [PATCH v2] gnu: z3: Build the Python bindings
From: |
Jakub Kądziołka |
Subject: |
bug#39754: [PATCH v2] gnu: z3: Build the Python bindings |
Date: |
Sun, 23 Feb 2020 17:59:56 +0100 |
On Sun, Feb 23, 2020 at 05:48:48PM +0100, Ludovic Courtès wrote:
> Hi!
>
> Jakub Kądziołka <address@hidden> skribis:
>
> > * gnu/packages/maths.scm (z3)[arguments]: Add the --python and
> > --pypkgdir flags to configure.
>
> Could you also mention the addition of #:modules and #:imported-modules?
Sure thing!
>
> > Changed the #:modules argument to only import site-packages from (guix
> > build python-build-system) as, as Ludo' pointed out on IRC, it also
> > exports %standard-phases, which could conflict with (guix build
> > gnu-build-system).
> >
> > I considered putting the Python bindings in a separate output; I decided
> > not to
> > do so as this change increases `guix size z3' from 116.4 MiB to 117.5
> > MiB, which is barely noticeable.
>
> Makes sense to me.
>
> LGTM, thanks!
Thanks! Pushed:
commit f6b4d395fd321d43fd548ba832c78320ac3f8d51
Author: Jakub Kądziołka <address@hidden>
Date: Sun Feb 23 16:11:30 2020 +0100
gnu: z3: Build the Python bindings
* gnu/packages/maths.scm (z3)[arguments]: Add the --python and
--pypkgdir flags to configure. To facilitate the latter, add
(guix build python-build-system) to #:modules and #:imported-modules.
signature.asc
Description: PGP signature