guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#39858] [PATCH] gnu: ccache: Update to 3.7.7.


From: Eric Bavier
Subject: [bug#39858] [PATCH] gnu: ccache: Update to 3.7.7.
Date: Mon, 02 Mar 2020 00:49:18 -0600
User-agent: Posteo Webmail

Hi Vincent, thanks for the patch, some comments below:

On 01.03.2020 11:48, Vincent Legoll wrote:
lightly tested: cache hits on trivial .c file compilation

And the tests still pass ;)

Trivial ./etc/indent-code.el housekeeping

Could you move this to a separate patch, please?

From 9718baa06727eb515030cf7b617a10e9fab8052a Mon Sep 17 00:00:00 2001
From: Vincent Legoll <address@hidden>
Date: Sun, 1 Mar 2020 17:59:10 +0100
Subject: [PATCH] gnu: ccache: Update to 3.7.7.

* gnu/packages/ccache.scm (ccache): Update to 3.7.7.
* gnu/packages/ccache.scm (ccache): Update source to github
* gnu/packages/ccache.scm (ccache): Update home-page to ccache.dev
* gnu/packages/ccache.scm (ccache): Add native inputs: asciidoc autoconf gperf
* gnu/packages/ccache.scm (ccache): Reindent arguments

Check the manual and other commit messages for formatting. In particular, the file name only needs to be mentioned once, and the affected sections are mentioned in square brackets before the comment.

---
gnu/packages/ccache.scm | 33 +++++++++++++++++++++------------
1 file changed, 21 insertions(+), 12 deletions(-)
...
- (method url-fetch)
- (uri (string-append "https://www.samba.org/ftp/ccache/ccache-";
- version ".tar.xz"))
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/ccache/ccache.git";)
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
(sha256
- (base32 "07wv75xdcxpdkfsz9h5ffrm8pjbvr1dh6wnb02nyzz18cdbjkcd6"))))
+ (base32 "1s8mq832chk95wa5qwaalralwv3ln1m931nrgd9a4gi19lg55zln"))))
(build-system gnu-build-system)

I think we can actually stick with the tarball available on the github release page: https://github.com/ccache/ccache/releases/download/v3.7.7/ccache-3.7.7.tar.xz which is already bootstrapped.

(native-inputs `(("perl" ,perl) ; for test/run
+ ("asciidoc" ,asciidoc)
+ ("autoconf" ,autoconf)
+ ("gperf" ,gperf)

Using the distribution tarball should prevent needing to add these inputs.

(description
"Ccache is a compiler cache. It speeds up recompilation by caching

It seems based on the release notes that we also need to remove the mention of Fortran 77 support in the description.

Could you send updated patches?

Cheers,
`~Eric






reply via email to

[Prev in Thread] Current Thread [Next in Thread]