[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#39839] [PATCH] gnu: suitesparse: Update to 5.7.1
From: |
Leo Famulari |
Subject: |
[bug#39839] [PATCH] gnu: suitesparse: Update to 5.7.1 |
Date: |
Wed, 4 Mar 2020 15:07:25 -0500 |
On Sat, Feb 29, 2020 at 04:46:47PM +0100, Felix Gruber wrote:
> * gnu/packages/math.scm (suitesparse): Update to 5.7.1
> [source]: The latest releases of SuiteSparse have only been published on
> GitHub. Fetch from git tag as GitHub releases page only contains
> autogenerated tarballs that guix lint complains about.
> [patches]: add patch for Mongoose's CMakeList.txt to find
> SuiteSparse_config.
> [arguments]: Add cmake flags used by new components GraphBLAS and
> Mongoose.
> [native-inputs]: add cmake and m4 needed to build GraphBLAS and Mongoose.
Thanks! Remember to also register the patch file in 'gnu/local.mk',
mention that in the commit message, and also mention the new patch file.
Check this commit for an example:
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=ca5e404f9a1ff81a38a32578c9c3a6c866482a9a
> - (method url-fetch)
> - (uri (string-append
> - "http://faculty.cse.tamu.edu/davis/SuiteSparse/SuiteSparse-"
> - version ".tar.gz"))
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/DrTimothyAldenDavis/SuiteSparse.git")
> + (commit (string-append "v" version))))
Okay.
> @@ -3429,6 +3432,14 @@ Fresnel integrals, and similar related functions as
> well.")
> "BLAS=-lblas"
> "TBB=-ltbb"
> "MY_METIS_LIB=-lmetis"
> + ;; Flags for cmake (only GraphBLAS and Mongoose)
Can you clarify "only GraphBLAS and Mongoose" here? Like, are these
flags so that we can build those components?
> diff --git a/gnu/packages/patches/suitesparse-mongoose-cmake.patch
> b/gnu/packages/patches/suitesparse-mongoose-cmake.patch
Can you add a comment at the beginning of this file explaining what
problem it solves?
Can you send a revised patch?
- [bug#39839] [PATCH] gnu: suitesparse: Update to 5.7.1,
Leo Famulari <=