[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#39932: [PATCH 1/3] gnu: python-xyz: Add python-distlib.
From: |
Jakub Kądziołka |
Subject: |
bug#39932: [PATCH 1/3] gnu: python-xyz: Add python-distlib. |
Date: |
Mon, 9 Mar 2020 00:22:57 +0100 |
On Sun, Mar 08, 2020 at 09:18:12PM +0100, Ludovic Courtès wrote:
> Hello,
>
> Jakub Kądziołka <address@hidden> skribis:
>
> > * gnu/packages/python-xyz.scm (python-distlib): New variable.
>
> [...]
>
> > + (modify-phases %standard-phases
> > + (add-before 'build 'no-/bin/sh
> > + (lambda _
> > + (substitute* '("distlib/scripts.py" "tests/test_scripts.py")
> > + (("/bin/sh") (which "sh")))))
> > + (add-before 'check 'prepare-test-env
> > + (lambda _
> > + (setenv "HOME" "/tmp")
> > + ;; NOTE: Any value works, the variable just has to be present.
> > + (setenv "SKIP_ONLINE" "1"))))))
>
> Please return #t from both phases, as is conventional.
Argh, I'm always forgetting about that. It would be nice to have a lint
for this...
> Apart from that, all 3 patches LGTM!
Thanks! I pushed the commits, the last one got a hash of
94d57ba3399aeb1b34d52e5e866c609f5a18ec2b
signature.asc
Description: PGP signature