[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#39741] [bug#39746] [PATCH 7/7] gnu: java-openjfx-web: Add new varia
From: |
levenson |
Subject: |
[bug#39741] [bug#39746] [PATCH 7/7] gnu: java-openjfx-web: Add new variable. |
Date: |
Mon, 09 Mar 2020 23:13:05 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Leo Famulari <address@hidden> writes:
> On Sat, Feb 22, 2020 at 09:17:55PM +0100, Alexey Abramov wrote:
>> * gnu/packages/java.scm (java-openjfx-build): Add patch to the base package.
>> *
>> gnu/packages/patches/java-openjfx-build-web-Check-xlocale.h-header-file.patch:
>> New
>> file. Remove hardcoded xlocale definitions.
>
> I have the same comments as previously. We need to fix up the commit
> message, add java-openjfx-web in a separate commit, and add some
> description to the xlocale patch file.
I fixed the comment, add description to the patch and split the change
into two commits.
> Can you send a revised patch series? You can add the argument
> '--subject-prefix=v2' to your `git send-email` or `git format-patch`
> command to distinguish the new patches from the old ones.
>
> Thanks!
Thank you for subject-prefix tip!
--
Alexey