[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#39292] [PATCH 01/10] gnu: Add python-pymediainfo
From: |
Leo Famulari |
Subject: |
[bug#39292] [PATCH 01/10] gnu: Add python-pymediainfo |
Date: |
Sun, 15 Mar 2020 14:47:28 -0400 |
On Sat, Mar 07, 2020 at 04:11:37PM +0100, Sebastian Schott wrote:
> * gnu/packages/python-xyz.scm (python-pymediainfo): New variable.
Thanks for this patch series Sebastian! Overall it looks good...
I only have one nitpick:
> + ;; Skip the only failing test "test_parse_url"
> + (invoke "pytest" "-vv" "-k" "not test_parse_url")
> + #t)))))
How does the test fail? We should add comments explaining why tests are
skipped, not just that they are fail so we skip them :)
And while you are adding that comment or fixing the test, can you rebase
the patches on the current master branch? They no longer apply due to
other changes in python-xyz.scm.
- [bug#39292] [PATCH 01/10] gnu: Add python-pymediainfo, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 04/10] gnu: Add python-d2to1, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 02/10] gnu: Add python-easygui, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 05/10] gnu: Add python-colour, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 09/10] gnu: Add python-tenacity, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 07/10] gnu: Add python-pyprind, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 06/10] gnu: Add python-gphoto2, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 10/10] gnu: Add rapid-photo-downloader, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 03/10] gnu: Add python-rawkit, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 08/10] gnu: Add python-colorlog, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 01/10] gnu: Add python-pymediainfo,
Leo Famulari <=