guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#40083: [PATCH] gnu: Add blktrace.


From: Marius Bakke
Subject: bug#40083: [PATCH] gnu: Add blktrace.
Date: Fri, 20 Mar 2020 18:35:50 +0100
User-agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu)

Vincent Legoll <address@hidden> writes:

> Is that better ?

LGTM.

> I intend to submit the rmtree patch (along a bunch of other cleanups)
> to upstream, will update guix packaging when that will happen...

Great!

[...]
  
> +(define-public blktrace
> +  (let ((commit "f4f8ef7cdea138cfaa2f3ca0ee31fa23d3bcf1cc")
> +        (revision "0"))

I added a comment about why we take this commit instead of the latest
tagged version.

[...]

> +           (add-after 'unpack 'fix-gnuplot-path
> +             (lambda* (#:key inputs #:allow-other-keys)
> +               (let ((gnuplot (assoc-ref inputs "gnuplot")))
> +                 (substitute* "btt/bno_plot.py"
> +                   (("gnuplot %s")
> +                    (string-append gnuplot "/bin/gnuplot %s")))))))))

...and ended this phase on a #t.

Applied!

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]