[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#40128] [PATCH 1/2] gnu: Add emacs-pretty-hydra.
From: |
Nicolas Goaziou |
Subject: |
[bug#40128] [PATCH 1/2] gnu: Add emacs-pretty-hydra. |
Date: |
Sat, 21 Mar 2020 17:38:28 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello,
"LaFreniere, Joseph" <address@hidden> writes:
> Patch file is attached.
Thank you.
> As noted in the description, this package is not intended for use by
> end-users. Is there a convention for communicating that?
I think specifying it in the description is the correct way.
> + (propagated-inputs
> + `(("emacs-hydra" ,emacs-hydra)
> + ("emacs-s" ,emacs-s)
> + ("emacs-dash" ,emacs-dash)))
Could you re-order them alphabetically?
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-before 'add-source-to-load-path 'remove-pretty-hydra
> + (lambda* (#:key outputs #:allow-other-keys)
> + ;; major-mode-hydra is packaged separately.
> + (delete-file "major-mode-hydra.el")
> + #t)))))
You can use #:exclude keyword from the Emacs build system instead.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou