[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#34638] [PATCH v2 4/4] inferior: Add 'open-inferior/container'.
From: |
Ludovic Courtès |
Subject: |
[bug#34638] [PATCH v2 4/4] inferior: Add 'open-inferior/container'. |
Date: |
Thu, 26 Mar 2020 10:32:27 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Christopher Baines <address@hidden> skribis:
> ---
> guix/inferior.scm | 76 +++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 76 insertions(+)
[...]
> +(define* (open-inferior/container store guix-store-item
> + #:key
> + (command "bin/guix")
> + (share-host-network? #f)
> + (extra-shared-directories '())
> + (extra-environment-variables '()))
Please add a docstring. Same comment as before regarding “extras”. :-)
> + (start-child-in-container
> + (list (string-append guix-store-item "/bin/guix")
> + ;; TODO I'm not sure why "repl" is duplicated in the following
> + ;; command
> + "repl" "repl" "-t" "machine")
This is the argv[0] issue mentioned earlier.
I think it’s not really feasible to write a test for this one, or at
least I don’t see how.
Otherwise LGTM, thanks!
Ludo’.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [bug#34638] [PATCH v2 4/4] inferior: Add 'open-inferior/container'.,
Ludovic Courtès <=