guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#40445: gnu: gsm: Update to 1.0.19.


From: maxim . cournoyer
Subject: bug#40445: gnu: gsm: Update to 1.0.19.
Date: Sun, 05 Apr 2020 14:20:56 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hi all,

address@hidden writes:

> Hello,
>
> "Raghav Gururajan" <address@hidden> writes:
>
>> Hi Mathieu!
>>
>>>> + #:make-flags
>>>> + (list
>>>> + ;; Added -fPIC with other default options.
>>>> + "CCFLAGS=-fPIC -c -O2 -DNeedFunctionPrototypes=1 -Wall -Wno-comment")
>>> 
>>> I wonder if we need all those options, the package seems to build fine
>>> without them. Could you have a look?
>>
>> Yes, Maxim and I, updated these options, to use libgsm in mediastreamer, as 
>> a part of linphone packaging. :-)
>>
>> Btw, currently the gsm package is in unusable state, after the commit 
>> "74c7f367daa554cedeb5f02a00d1cd02acf1584b".
>>
>> Regards,
>> RG.
>
> Ooops.  Sorry about that.  I meant:
>
> -       #:make-flags '("INSTALL_ROOT=%output"
> -                      "CCFLAGS=-fPIC \
> +       #:make-flags (list (string-append "INSTALL_ROOT=" %output)
> +                          "CCFLAGS=-fPIC \
>
> But I'll take into accounts comments from Mathieu, which make sense.
>
> Maxim

I've fixed the breakage I caused with commit
5b05f8e9654ea722270c45c0fd0eead369bc0daf, and committed the update to
gsm 1.0.19 from Raghav on top as
5e16e4401f854d39f5fbebaf247750e554bd4a09.

Closing.

Thanks for the ideas!

Maxim





reply via email to

[Prev in Thread] Current Thread [Next in Thread]