guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#40591: Add emacs-org-roam


From: Nicolas Goaziou
Subject: bug#40591: Add emacs-org-roam
Date: Tue, 14 Apr 2020 11:08:52 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hello,

Alberto EFG <address@hidden> writes:

> Added emacs-org-roam. I used it all day, seems like  everything works.

Thank you. 

I applied your patch with the following changes.
> +(define-public emacs-org-roam
> +  (package
> +   (name "emacs-org-roam")

The indentation is off. If you use Emacs, you can press M-q, otherwise,
you may call the etc/indent.el script in Guix source tree.

> +   (version "1.0.0")
> +   (source
> +    (origin
> +     (method git-fetch)
> +     (uri (git-reference
> +           (url "https://github.com/jethrokuan/org-roam.git";)
> +           (commit "1433dbc31602c412914c71ecc81aa5dcf6b03daf")))

When there is an official release, we use the tag. Therefore, I changed
the line above to:

  (commit (string-append "v" version))

> +     (file-name (git-file-name name version))
> +     (sha256
> +      (base32
> +       "08pfa63k194dpk0y2gfa0nzn5lig81q0l9axkq5j4ibj6ifaap4a"))))

Nitpick: I put the string on the line above.

> +   (build-system emacs-build-system)
> +   (propagated-inputs
> +    `(("emacs-company" ,emacs-company)
> +      ("emacs-emacsql-sqlite" ,emacs-emacsql)
> +      ("emacs-dash" ,emacs-dash)
> +      ("emacs-f" ,emacs-f)
> +      ("emacs-s" ,emacs-s)
> +      ("emacs-org-ref" ,emacs-org-ref)))

I re-ordered the inputs alphabetically.

> +   (license license:gpl3)))

The license is actually gpl3+, as written in the source code.

Regards,

-- 
Nicolas Goaziou





reply via email to

[Prev in Thread] Current Thread [Next in Thread]