guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#40677] [PATCH 01/18] gnu: jami: Move Jami and its dependencies to j


From: Mathieu Othacehe
Subject: [bug#40677] [PATCH 01/18] gnu: jami: Move Jami and its dependencies to jami.scm.
Date: Wed, 22 Apr 2020 10:59:39 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hello Jan,

Thanks for the updated serie. I see it has shrunk a bit, which is good!
First two general remarks. As explained by Christopher, you need to
make sure that you pass the version of the patchset to git.

You also need to write commit messages respecting this
https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs
as I already told you.

> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2019 Pierre Neidhardt <address@hidden>

Why is Pierre copyright here?

> +;;; Copyright © 2019, 2020 Jan Wielkiewicz <address@hidden>

I'm not sure what's the copyright policy when moving stuff to new
files. Someone?

Thanks,

Mathieu





reply via email to

[Prev in Thread] Current Thread [Next in Thread]