[bug#40928] Subject: [PATCH 2/2] gnu: Add emacs-kakoune.

[Nicolas Goaziou]

Hello,

pinoaffe <address@hidden> writes:

> +(define-public emacs-kakoune
> +  (package
> +    (name "emacs-kakoune")
> +    (version "20191017.1502")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append
> +               "https://melpa.org/packages/kakoune-";
> +               version
> +               ".tar"))

See my previous comments about MELPA packaging and versioning.

> +        (sha256
> +          (base32
> +            "1srrrv4fxf99iypch6wyqmiyij4dmq0yrnqnim0y4q0dfvpj63r8"))))

See also my comments about alignment here.

> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +      `(("emacs-ryo-modal"        ,emacs-ryo-modal)
> +        ("emacs-multiple-cursors" ,emacs-multiple-cursors)
> +        ("emacs-expand-region"    ,emacs-expand-region)))
> +    (home-page
> +      "https://github.com/jmorag/kakoune.el";)
> +    (synopsis
> +      "A simulation, but not emulation, of kakoune")

Maybe:

  Simple simulation of Kakoune inside of Emacs

> +    (description
> +      "This package provides many, but not all of the editing primitives in 
> the kakoune editor.

kakoune -> Kakoune

> +Unlike evil-mode for vim, this is very shallow emulation, and seeks to do as 
> little

Maybe:

  Unlike, Evil mode for Vim, this is a very shallow emulation, which ...

or even:

  This is a very shallow emulation, which ...

> +work as possible, leveraging Emacs native editing commmands and the work of 
> other
> +packages wherever possible.")

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou