[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#40631: [PATCH 0/4] Build QEMU with smartcard support, to get GNOME B
From: |
Christopher Baines |
Subject: |
bug#40631: [PATCH 0/4] Build QEMU with smartcard support, to get GNOME Boxes working |
Date: |
Sun, 03 May 2020 10:43:59 +0100 |
User-agent: |
mu4e 1.2.0; emacs 26.3 |
Brice Waegeneire <address@hidden> writes:
> I was thinking of packaging libcacard the other day, thankfully you've
> already
> done it.
>
> If I understand correctly softhsm is needed to test libcacard, but
> it's tests
> can't be enabled because our gnutls is missing some features and
> rebuilding it
> would rebuild the world, right?
Yep, I've got a bug open for that change [1].
1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=40654
>> + (name "softhsm")
>> + (version "2.5.0")
>> + (source (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "https://dist.opendnssec.org/source/"
>> + "softhsm-" version ".tar.gz"))
>
> The latest version is 2.6.0, even though the home-page don't list it,
> it's present
> in the source you defined or in their Github page[0].
Ah, interesting, I've updated the package to 2.6.1.
>> + (add-after 'unpack 'patch
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + (substitute* "tests/setup-softhsm2.sh"
>> + (("\\/usr\\/lib64\\/pkcs11\\/libsofthsm2\\.so")
>> + (string-append (assoc-ref inputs "softhsm")
>> + "/lib/softhsm/libsofthsm2.so")))
>> + #t)))))
>
> Instead of 'patch' 'patch-tests' would be more descriptive.
Sure, I've changed the phase name.
> LGTM otherwise, building and linting is successful.
Great, I've gone ahead and pushed these patches as
17adb70f78b34a490b8e692f1a110cef72097685.
Thanks for taking a look!
Chris
signature.asc
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#40631: [PATCH 0/4] Build QEMU with smartcard support, to get GNOME Boxes working,
Christopher Baines <=