[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41360] [PATCH 03/12] gnu: java-openjfx-graphics: Implement a comple
From: |
Ludovic Courtès |
Subject: |
[bug#41360] [PATCH 03/12] gnu: java-openjfx-graphics: Implement a complete compilation. |
Date: |
Sat, 23 May 2020 16:04:29 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Alexey Abramov <address@hidden> skribis:
> ---
> gnu/packages/java.scm | 643 +++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 635 insertions(+), 8 deletions(-)
Please add a commit log.
> + (java-aux-class?
> + (lambda (class)
> + (string-match "\\$[0-9]+.class" class)))
Probably “\\.class” instead of “.class”?
> + (add-after 'chdir-to-a-module-directory 'compile-prism-compilers
> + (lambda _
Maybe add a comment explaining why this phase is necessary.
> + (let ((prism-compilers-classes
> "build/classes/jsl-compilers/prism")
> + (prism-src "src/main/jsl-prism/"))
> + (mkdir-p prism-compilers-classes)
> + (apply invoke `("javac"
> + "-d" ,prism-compilers-classes
> + ,@javac/h-flags
> + ,@(find-files prism-src "\\.java"))))
This can be shortened as:
(apply invoke "javac" "-d" prism-compilers-classes
(append javac/h-flags (find-files prism-src "\\.java")))
These two comments apply to the other phases too.
More generally, why are there so many phases? How do people normally
build it? Gradle?
Would it make sense to factorize helpers in a new (gnu build
java-openjfx) module or similar?
Thanks,
Ludo’.
- [bug#41360] [PATCH 00/12] Package java-openjfx, Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 01/12] gnu: java-openjfx-build: Add helpful patch., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 02/12] gnu: java-openjfx-build: Fix indentation., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 05/12] gnu: java-openjfx-swing: Add new variable., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 06/12] gnu: java-openjfx-swt: Add new variable., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 07/12] gnu: java-openjfx-controls: Add new variable., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 03/12] gnu: java-openjfx-graphics: Implement a complete compilation., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 03/12] gnu: java-openjfx-graphics: Implement a complete compilation.,
Ludovic Courtès <=
- [bug#41360] [PATCH 09/12] gnu: java-openjfx-web: Add new variable., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 04/12] gnu: java-openjfx-build: Fix openjfx-swing component build for JDKu8, Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 08/12] gnu: java-openjfx-build: Prepare a patch to build openjfx-web., Alexey Abramov, 2020/05/17
- [bug#41360] [PATCH 01/12] gnu: java-openjfx-build: Add helpful patch., Ludovic Courtès, 2020/05/23
- [bug#41360] [PATCH v2 1/9] gnu: java-openjfx-build: Add helpful patch., Alexey Abramov, 2020/05/30