[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41324] [PATCH v2] gnu: Add dump.
From: |
Marius Bakke |
Subject: |
[bug#41324] [PATCH v2] gnu: Add dump. |
Date: |
Sat, 23 May 2020 21:14:24 +0200 |
User-agent: |
Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) |
Hi Marcin,
Marcin Karpezo <address@hidden> writes:
> * gnu/packages/backup.scm (dump): New variable.
Thanks! Can't believe we've gone without this for so long.
[...]
> +(define-public dump
> + (package
> + (name "dump")
> + (version "0.4b46")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://downloads.sourceforge.net/project/" name
> "/"
> + name "/" version "/" name "-" version ".tar.gz"))
Please use "mirror://sourceforge" here.
> + (sha256
> + (base32
> + "15rg5y15ak0ppqlhcih78layvg7cwp6hc16p3c58xs8svlkxjqc0"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:configure-flags
> + `("--sysconfdir=/etc"
> + "--disable-readline"
> + "--disable-rmt")))
> + (native-inputs
> + `(("pkg-config" ,pkg-config)
> + ("autoconf" ,autoconf)
> + ("zlib" ,zlib)
> + ("util-linux" ,util-linux "lib")
> + ("e2fsprogs" ,e2fsprogs)
> + ("automake" ,automake)))
I ran 'guix size dump' and noticed that the package keeps references to
util-linux, zlib and e2fsprogs. Probably they should be "inputs"
instead. Can you confirm and send an updated patch?
Otherwise looks great, thanks!
signature.asc
Description: PGP signature