[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41820] [PATCH] file-systems: Add record type <nfs-share> for a file
|
From: |
Mathieu Othacehe |
|
Subject: |
[bug#41820] [PATCH] file-systems: Add record type <nfs-share> for a file system device. |
|
Date: |
Sun, 21 Jun 2020 11:35:59 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello Stefan,
Thanks a lot for this patch, overall it look nice! Without going into
details here are a few remarks:
* As you probably noticed the bootloading & system part of Guix is
moving a lot recently. This patch does not apply on master, so it would
be nice if you could rebase it and pass "--base=auto" option to "git
format-patch" so that it's easier to apply it.
* It would be nice to have tests for this functionality. There's already
a (gnu tests nfs) module, testing the NFS service. Maybe you could add a
test case of a marionette booting from a local NFS share.
* Finally, now that file-system "device" field can be a label, a UUID, a
"/dev" node and an "nfs-share", it makes me think that we could need a
new layer of abstraction here, but this can come later and I need to
think more about it.
Thanks,
Mathieu