[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41995] [PATCH 1/2] gnu: Add symengine.
From: |
Nicolas Goaziou |
Subject: |
[bug#41995] [PATCH 1/2] gnu: Add symengine. |
Date: |
Wed, 24 Jun 2020 08:57:44 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello,
Vinicius Monego <monego@posteo.net> writes:
> * gnu/packages/algebra.scm (symengine): New variable.
Thank you.
I couldn't build it because gperftools currently has a failing test.
> + '(#:configure-flags
> + '("-DCMAKE_BUILD_TYPE=Release"
> + "-DWITH_GMP=on"
> + "-DWITH_MPFR=on"
> + "-DWITH_MPC=on"
> + "-DINTEGER_CLASS=flint"
> + "-DWITH_LLVM=on"
> + "-DWITH_SYMENGINE_THREAD_SAFE=on"
IIUC correctly, these are the suggested build options in the README. It
may be worth adding a comment about it since this looks a bit
opinionated.
> + "-DWITH_TCMALLOC=on")))
This does not belong to the set of suggested build options. Is there
a particular reason to activate it? If so, would it make sense to add
a comment about it?
I also see there is a "BUILD_SHARED_LIBS" flag, off by default. Would it
make sense to activate it?
> + (license (list license:expat ;; SymEngine.
> + license:bsd-3)))) ;; Third party code.
In both comments, there should be a single semicolon and no full stop.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou