[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#42048] [PATCH 3/6] channels: Remove 'signature' from <channel-intro
From: |
Ricardo Wurmus |
Subject: |
[bug#42048] [PATCH 3/6] channels: Remove 'signature' from <channel-introduction>. |
Date: |
Tue, 30 Jun 2020 16:35:14 +0200 |
User-agent: |
mu4e 1.4.10; emacs 26.3 |
Ludovic Courtès <ludo@gnu.org> writes:
> In the end signing the commit/key pair does not buy us much. Someone
> publishing a valid but different commit/key pair would effectively be
> publishing a different channel, which could be a fork (made by a former
> authorized developer) or simply a mirror. In the latter case, there's
> nothing to be gained by publishing a different commit/key pair.
>
> * guix/channels.scm (<channel-introduction>)[signature]: Remove.
> (make-channel-introduction): Adjust accordingly.
> ---
[…]
> (define (make-channel-introduction commit signer)
> "Return a new channel introduction: COMMIT is the introductory where
> authentication starts, and SIGNER is the OpenPGP fingerprint (a bytevector)
> of
> the signer of that commit."
> - (%make-channel-introduction commit signer #f))
> + (%make-channel-introduction commit signer))
Do we still need this procedure at all? Looks like
%make-channel-introduction could simply be renamed to make-channel-introduction.
--
Ricardo