[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#42183] [PATCH] gnu: Add emacs-literate-calc-mode.
From: |
Nicolas Goaziou |
Subject: |
[bug#42183] [PATCH] gnu: Add emacs-literate-calc-mode. |
Date: |
Tue, 07 Jul 2020 14:37:00 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello,
Morgan.J.Smith@outlook.com writes:
> * gnu/packages/emacs-xyz.scm (emacs-literate-calc-mode): New variable.
Thank you.
> + (version "20200703.723")
Even though there is no actual release, the version, as specified in the
".el" file, is "0.1". So you need to bind a `version' and a `revision',
and add a comment about it at the top of the package.
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://melpa.org/packages/literate-calc-mode-"
> + version ".el"))
We don't use source from MELPA. Please use `git-fetch' instead.
> + (sha256
> + (base32
> + "1ck5ha12jrs6sfhhf3yaydji49bzakrk59agspg5xynxv22aka1v"))))
Please move the hash on the same line as `base32'.
> + (build-system emacs-build-system)
> + (propagated-inputs
> + `(("emacs-s" ,emacs-s)))
> + (home-page "https://github.com/sulami/literate-calc-mode.el")
> + (synopsis "Literate programming for Emacs calc")
-> for Emacs Calc
> + (description "Displays inline results for calculations, supports
> +variables and updates as you type (if you want). Also works in your
> +favourite markup mode.")
The description should contain complete sentences, e.g.
This library displays inline results... and supports...
Could you send an updated patch?
Regards,
--
Nicolas Goaziou