guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#41679] [PATCH] gnu: Update protonvpn-cli to 2.2.4


From: Ludovic Courtès
Subject: [bug#41679] [PATCH] gnu: Update protonvpn-cli to 2.2.4
Date: Wed, 09 Sep 2020 23:08:29 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hi Ryan,

Ryan Prior <rprior@protonmail.com> skribis:

> * gnu/packages/vpn.scm (protonvpn-cli): Update to 2.2.4

Applied!

Brice Waegeneire <brice@waegenei.re> skribis:

> The update is fine, but that package is missing several dependencies, at
> least: python-jinja2, coreutils and iproute. Try running it in a pure
> environment and it will crash “guix environment --pure --container
> --ad-hoc protonvpn-cli -- protonvpn -h”.
>
> Searching the source for “subprocess.run” I find call to other binaries
> which aren't listed as dependencies. Could you wrap the “protonvpn”
> binary with the “PATH” of all the binaries it uses to avoid propagating
> a whole lot of packages. Probably only “python-jinja2” should be
> propagated.

Alternatively, we can substitute file names (of jinja2, coreutils, and
iproute programs) with absolute file names.

That can be addressed separately, though.

Thanks,
Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]