guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#42281] [PATCH] gnu: Add python-buku.


From: Alexandros Theodotou
Subject: [bug#42281] [PATCH] gnu: Add python-buku.
Date: Thu, 10 Sep 2020 16:57:53 +0100
User-agent: Evolution 3.34.2

Hi Marius,

On Tue, 2020-07-21 at 00:29 +0200, Marius Bakke wrote:
> As this seems like a general-purpose tool and not a Python library,
> it
> would be good to place this elsewhere.  I'm not sure where though,
> maybe
> (gnu packages web)?
> 
> Also I think the 'python-' prefix can be removed.

Done.

> > +    (arguments
> > +      `(#:tests? #f)) ; needs python-mypy-extensions which fails
> > to build
> 
> Actually python-mypy-extensions seems to not be in Guix at all.  Can
> you
> adjust the comment with a TODO?

Done.

> 
> > +    (propagated-inputs
> > +      `(("python-html5lib" ,python-html5lib)
> > +        ("python-urllib3" ,python-urllib3)
> > +        ("python-beautifulsoup4" ,python-beautifulsoup4)
> > +        ("python-pytest" ,python-pytest)
> > +        ("python-pytest-cov" ,python-pytest-cov)
> > +        ("python-pylint" ,python-pylint)
> > +        ("python-vcrpy" ,python-vcrpy)))
> 
> These can probably be regular inputs, as python-build-system will
> automatically 'wrap' the executables with these on PYTHONPATH.

Done.

> 
> > +    (home-page "https://github.com/jarun/buku";)
> > +    (synopsis
> > +      "Bookmark manager")
> > +    (description
> > +      "buku is a powerful bookmark manager written in Python3 and
> > SQLite3.")
> 
> It's a chore, but it would be great if you could expand on the
> description.  Something along the lines of "@command{buku} can
> auto-import bookmarks from your browser and present them in an
> interactive command-line interface that lets you compose and update
> bookmarks directly.  It can also present them in a web interface with
> @command{bukuserver}."

Added your proposed text.

> Can you send an updated patch?

Please find the new patch attached.

Thanks,
Alex

Attachment: 0001-gnu-Add-buku.patch
Description: Text Data

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]