[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#43340] [PATCH 4/5] daemon: Spawn 'guix authenticate' once for all.
From: |
Mathieu Othacehe |
Subject: |
[bug#43340] [PATCH 4/5] daemon: Spawn 'guix authenticate' once for all. |
Date: |
Sat, 12 Sep 2020 09:20:04 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
> + (send-reply 500
Reply codes could be factorized in an enum.
> + if (!agent) {
> + Strings args = { "authenticate" };
> + agent = std::shared_ptr<Agent>(new Agent(settings.guixProgram, args));
> + }
make_shared should be preferred to the direct use of new.
> + if (strchr("0123456789", ch)) {
You can maybe use isdigit?
Thanks,
Mathieu