[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41219] [PATCH 2/2] guix: Enforce package.json "files" directive.
From: |
Jelle Licht |
Subject: |
[bug#41219] [PATCH 2/2] guix: Enforce package.json "files" directive. |
Date: |
Tue, 22 Sep 2020 20:09:19 +0200 |
Hey Giacomo,
paul <goodoldpaul@autistici.org> writes:
>>> + install-dir)
>>> + (begin
>>> + (copy-recursively "." install-dir)
>>> + ;; Remove references to dependencies
>>> + (delete-file-recursively
>>> + (string-append install-dir "/node_modules"))))
>>> + (if (and main
>>> + (not (file-exists?
>>> + (string-append
>>> + install-dir "/" (dirname main)))))
^
{New,Forgotten} nitpick; this only checks for the `dirname': why not
just `(string-append install-dir "/" main)'? Because if
e.g. "lib/utils.js" is in "files", and main is "lib/main.js", it seems
that main would not be installed with this snippet. Does that make
sense?
Thanks in advance,
- Jelle