|
From: | Miguel Ángel Arruga Vivas |
Subject: | [bug#44321] [PATCH 4/6] guix build: Move transformation options to (guix transformations). |
Date: | Sat, 31 Oct 2020 00:03:03 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi Ludo, Ludovic Courtès <ludo@gnu.org> writes: > * guix/transformations.scm: New file. The main comment regarding this patch is that file has to be added to po/guix/POTFILES.in, or the translations will be lost. I've seen that you've changed some code identifiers, here: > - (else (tarball-base-name (file-sans-extension file-name))))) > + (_ (tarball-base-name (file-sans-extension file-name))))) And there: > - (x > + (_ And these changes seem sensible as the match parameter is unused. Other than the first comment, the patch LGTM. Happy hacking, Miguel
[Prev in Thread] | Current Thread | [Next in Thread] |