[bug#43133] Update Chez to 9.5.4, Add a static output for lz4

[Ludovic Courtès]

Hi Brendan,

Apologies for the long delay; I guess quite a few patches that arrived
during the summer fell through the cracks.  :-/

Brendan Tildesley <mail@brendan.scot> skribis:

> I haven't tested it but it seems to work. I wanted to build some of
> the dependent packages against it but i noticed chez-irregex,
> chez-sockets, chez-scmutils are all broken anyway. chez-fmt builds at
> least.

That should be fixed now as Martin pointed out:

  https://issues.guix.gnu.org/42947

>>From c81a0521d44f6dc6fa70b745b4062db2fc89a5b6 Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <mail@brendan.scot>
> Date: Mon, 31 Aug 2020 16:39:02 +1000
> Subject: [PATCH 1/3] gnu: lz4: Install static build to "static" output.
>
> * gnu/packages/compression.scm (lz4): Mimic the zlib package by moving
> the static build output to a separate "static" output. This allows
> programs like chez-scheme to link to the static version.

The patch LGTM.  In theory it should go to ‘staging’, I have to check
what the status is.

>>From 4e7d52173cee354e5ac0dfedd6f22b95e96ffe86 Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <mail@brendan.scot>
> Date: Mon, 31 Aug 2020 17:26:17 +1000
> Subject: [PATCH 2/3] gnu: chez-scheme: Update to 9.5.4.
>
> * gnu/packages/chez.scm
> (nanopass): Update to 1.9.1.
> (stex): Update to 1.2.2.
> (chez-scheme): Update to 9.5.4.
> [inputs]: Add newly required lz4 and lz4:static.
> [arguments]:
>  - Remove unused zlib symbol.
>  - Since we are using ZLIB=, it looks like the substitution of libz.a path in
>  .c/Mf-... files is no longer needed.
>  - add lz4-static symbol and use new LZ4= and ZLIB= configure options to
>    point to their static binaries.

[...]

>                 (substitute* "stex/Makefile"
>                   (("PREFIX=/usr") (string-append "PREFIX=" out)))
>                 (invoke "./configure" "--threads"
> +                       (string-append "ZLIB=" zlib-static "/lib/libz.a")
> +                       (string-append "LZ4=" lz4-static "/lib/liblz4.a")

Why should Chez static-link against those?  In general we should avoid
that as that prevents security update propagation through grafts.  Can
we remove these two lines?

>>From 939a1f8185f7e77ff1b809e6cc8de6fbf43b9768 Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <mail@brendan.scot>
> Date: Mon, 31 Aug 2020 21:51:34 +1000
> Subject: [PATCH 3/3] gnu: chez-scheme: Patch more hard-coded paths.
>
> * gnu/packages/chez.scm (chez-scheme): Patch out some /bin/rm and
> /bin/echo references.

LGTM.

Thank you!

Ludo’.