[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#44470] [PATCH] gnu: Added emacs-solidity.
From: |
Nicolas Goaziou |
Subject: |
[bug#44470] [PATCH] gnu: Added emacs-solidity. |
Date: |
Thu, 05 Nov 2020 18:07:44 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hello,
Martin Becze <mjbecze@riseup.net> writes:
> * gnu/packages/emacs-xyz.scm (emacs-solidity): New variable.
Thank you.
> + ;; No release.
> + (let ((commit "d166a86b83907e0cfd64c191e9dfce4b44a9843e"))
Is there any reason to use this particular instead of
e91c36cc20a2e683b930712a7f9c0ab28451b347, which is the exact "0.1.10"
release? If so, please mention it in the comment above.
> + (package
> + (name "emacs-solidity")
> + (version (git-version "0.1.10" "1" commit))
If we use the commit above, `version' can simply become "0.1.10".
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/ethereum/emacs-solidity")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "19hgvsrqch2vp49ag6m76bi5qxd20v95z0ib838rib9as15b17wq"))))
> + (build-system emacs-build-system)
> + (propagated-inputs
> + `(("emacs-company" ,emacs-company)
> + ("emacs-flycheck" ,emacs-flycheck)))
> + (home-page "https://github.com/ethereum/emacs-solidity")
> + (synopsis "Major mode for writing Solidity code")
> + (description "A simple language mode for the Solidity language. It is
> a
> +constant work in progress as the language itself also progresses.")
The first sentence should be "complete", i.e., with a subject and
a verb.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou