[bug#44567] [PATCH] publish: Improve HTTP performance when not using --cache.

[Ludovic Courtès]

Hi,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> I didn't observe any meaningful difference, it perhaps felt more
> 'steady'.  The value comes from what Linux, the kernel, configures as a
> max value by default (see 'man tcp' and 'cat
> /proc/sys/net/core/wmem_max').

I see, makes sense!

>>>       (make-gzip-output-port (response-port response)
>>>                              #:level level
>>> -                            #:buffer-size (* 64 1024)))
>>> +                            #:buffer-size %default-buffer-size))
>>
>> Does the gzip buffer size have to match the TCP buffer size?  I’d say
>> not necessarily, so perhaps we should have a separate variable for the
>> gzip buffer size (or keep it as is).
>
> It doesn't, but if we're going to pick some value, it seems the network
> one (SO_SNDBUF) should be the lowest common denominator.  Since we're
> augmenting the previous value, I've just all made them agree.

OK.

>> That’s it, thank you!
>
> Thanks for the review!  Pushed to the 1.2.0-version branch.

Great, thanks!

Ludo’.