[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#44427] [PATCH] lint: Add 'check-haskell-stackage' checker.
From: |
Ludovic Courtès |
Subject: |
[bug#44427] [PATCH] lint: Add 'check-haskell-stackage' checker. |
Date: |
Wed, 18 Nov 2020 22:45:42 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi Timothy,
Timothy Sample <samplet@ngyro.com> skribis:
> To make the test work, I made sure our Hackage and Stackage importers
> use base URLs that are parameters. Then, I used ‘with-http-server’ and
> ‘parameterize’d the URLs to use the local server. (This all follows the
> example of the SWH checker.) It might be clearer if the test were split
> in two, but the Stackage importer memoizes the list of packages sent
> from the Stackage server. That means that the two tests would have to
> be run in a certain order to work, which is pretty dodgy.
>
> Is the test too complicated to be worth it? I might be able to make it
> a little clearer, but I’m not sure it’s worth including at all.
> Thoughts?
I think it’s fine.
>>From 7e01e8adddeaba7a2c0b3a79425da26f3c2584df Mon Sep 17 00:00:00 2001
> From: Timothy Sample <samplet@ngyro.com>
> Date: Tue, 3 Nov 2020 15:30:28 -0500
> Subject: [PATCH] lint: Add 'check-haskell-stackage' checker.
>
> * guix/lint.scm (check-haskell-stackage): New procedure.
> (%network-dependent-checkers): Add 'haskell-stackage' checker.
> * guix/import/hackage.scm (%hackage-url): New variable.
> (hackage-source-url, hackage-cabal-url): Use it in place of a
> hard-coded string.
> * guix/import/stackage.scm (%stackage-url): Make it a parameter.
> (stackage-lts-info-fetch): Update accordingly.
> * tests/lint.scm ("hackage-stackage"): New test.
LGTM, thank you!
‘%stackage-updater’ only offers versions that are in LTS Stackage,
right?
Ludo’.