[bug#39480] [PATCH] gnu: Add zig compiler

[Christopher Baines]

Leo Famulari <leo@famulari.name> writes:

> On Fri, Feb 07, 2020 at 01:40:41PM +0100, Simon Nielsen wrote:
>> Hi,
>> 
>> Adds the zig compiler as a new file in `gnu/packages/`
>
> Thanks! Please add it to 'gnu/local.mk'.
>
>> +(define-public zig-0.5.0
>
> We can name it 'zig' until there are multiple versions in Guix.
>
>> +     `(#:tests? #f
>
> Why are the tests disabled? Is it because there is no test suite? Or
> something else? Please add a brief code comment explaining it.
>
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-before 'build 'fix-build
>> +           (lambda _ (setenv "HOME" "/tmp") #t)))))
>
> I guess that the build tries to access $HOME?
>
>> +    (description
>> +      "Programming languaged designed for robustness, optimality, and 
>> clarity")
>
> Can you try to make a more detailed description here? At least it should
> be a complete sentence.
>
>> +    (synopsis
>> +      "Programming languaged designed for robustness, optimality, and 
>> clarity")
>
> Typo: languaged

It's been a few months, is this patch still relevant?

Thanks,

Chris

signature.asc
Description: PGP signature