guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#42295] [PATCH] gnu: rust-1.44: Add rustfmt output.


From: Matthew Kraai
Subject: [bug#42295] [PATCH] gnu: rust-1.44: Add rustfmt output.
Date: Thu, 26 Nov 2020 05:25:48 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.4.0

Hi John,

On 11/25/20 6:46 AM, John Soo wrote:
Hi Matthew,

Thanks! I had packaged rustfmt-nightly but this is much better.

Matthew Kraai <kraai@ftbfs.org> writes:

+             (replace 'check
+               (lambda* _
+                 ;; Enable parallel execution.
+                 (let ((parallel-job-spec
+                        (string-append "-j" (number->string
+                                             (min 4
+                                                  (parallel-job-count))))))
+                   (invoke "./x.py" parallel-job-spec "test" "-vv")
+                   (invoke "./x.py" parallel-job-spec "test"
+                           "src/tools/cargo")
+                   (invoke "./x.py" parallel-job-spec "test"
+                           "src/tools/rustfmt"))))
Nice!

+      (outputs '("out" "doc" "cargo" "rustfmt"))
Perhaps we should make anything that can be installed as a rustup
component an output (provided the source is in the rust tree). I think
rls can be added immediately in the same fashion.
Is rls deprecated in favor of rust-analyzer?
Do you want to add a copyright line?
Done.
Otherwise, this looks good to me.

According to https://github.com/rust-lang/rustfmt, rustfmt was made a component in 1.24.0.  Would it be better to add this support to the rust-1.24 package instead?  I've attached the patch I'm currently testing.

--
Matthew Kraai

Attachment: patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]