guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#45707] [PATCH v2] gnu: Add obs-v4l2sink.


From: Nicolò Balzarotti
Subject: [bug#45707] [PATCH v2] gnu: Add obs-v4l2sink.
Date: Thu, 07 Jan 2021 01:11:17 +0100

Thanks for the update.

Evan Straw <evan.straw99@gmail.com> writes:
> +              (method git-fetch)
> +              (uri (git-reference (url 
> "https://github.com/CatxFish/obs-v4l2sink";)
> +                                  (commit version)))


I'm not 100% sure (I usually don't do patch review) but I think the
indentation is wrong (line should break after git-reference).

> +    (inputs `(("qtbase" ,qtbase)
> +              ("obs" ,obs)))
I think it's the same after inputs..

> +    (description "An @dfn{Open Broadcaster Software} (OBS) Studio plugin that
> +provides output capabilities to a @dfn{Video4Linux2} (v4l2) device.  It can 
> be
> +used with @code{v4l2loopback} to achieve cross-program video transfer between
I think that instead of definitions, those are acronyms, so it should be
@acronym{OBS, Open Broadcaster Software} and @acronym{Video 4 Linux 2,
vl42}.

I'd say that you should wait for somebody that knows better than me
before applying my suggestions.

It builds and lint is ok, but obs does not work on my laptop (video card
too old) so I cannot test that it run.

Nicolo





reply via email to

[Prev in Thread] Current Thread [Next in Thread]