guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#45712] [PATCHES] Improve Python package quality


From: Lars-Dominik Braun
Subject: [bug#45712] [PATCHES] Improve Python package quality
Date: Tue, 26 Jan 2021 09:39:22 +0100

Hi Maxim,

> Attached is a small rework of your original patch.  I've made the Python
> script standalone, which should make it easier to maintain.  I've also
> refactored the tests somewhat and added your copyright information.
> Is this OK with you?
sure, no problem with the refactoring in gerenal, but I think you used
an old patchset. I sent a v2 to this issue, which had some changes to
the scripts and tests.

I can’t test your patch properly unfortunately, because `make check`
does not work on core-updates and trying to build any Python package on
core-updates triggers the requirements checker immediately: 

validating 'attrs' 
/gnu/store/hdjip92izsf9anfhd6ijgc9glvbi4dzv-python-attrs-bootstrap-19.3.0/lib/python3.9/site-packages
...checking requirements: ERROR: attrs==19.3.0 The 'attrs==19.3.0' distribution 
was not found and is required by the application”)

Maybe that’s an issue with Python 3.9?

Cheers,
Lars






reply via email to

[Prev in Thread] Current Thread [Next in Thread]