guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#45972] [PATCH] Add julia-json with dependencies


From: Ludovic Courtès
Subject: [bug#45972] [PATCH] Add julia-json with dependencies
Date: Tue, 26 Jan 2021 22:33:37 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Hi Nicolò,

Nicolò Balzarotti <anothersms@gmail.com> skribis:

> This patch series adds julia-json together with its dependencies.

Neat.  I looked at it quickly and it LGTM.  Nitpicks:

> +    (synopsis "Julia implementation of associative containers that preserve
> +insertion order")

Maybe remove “Julia implementation of”.

> +    (description "This package implements OrderedDicts and OrderedSets, which

Ideally use @code for identifiers.

> +    (synopsis "Fixed point types for julia")

s/julia/Julia/

> +    (synopsis "JSON parsing and printing")
> +    (description "Parsing and printing JSON in pure Julia.")

Please make that a full sentence.

If you’re confident with the licenses and ‘guix lint’ is happy,
please push!  Nice to see more Julia packages.

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]