guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#46015] [PATCH] Add xkeysnail.


From: Ludovic Courtès
Subject: [bug#46015] [PATCH] Add xkeysnail.
Date: Fri, 29 Jan 2021 12:03:51 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Hi,

Z572 <873216071@qq.com> skribis:

>>From c8ffb0e96851e5642fa872f5ffc20d9e56d30fb7 Mon Sep 17 00:00:00 2001
> From: Zheng Junjie <873216071@qq.com>
> Date: Thu, 21 Jan 2021 18:36:16 +0800
> Subject: [PATCH 1/2] gnu: Add python-inotify-simple.
>
> ---
>  gnu/packages/python-xyz.scm | 33 ++++++++++++++++++++++++++++++++-
>  1 file changed, 32 insertions(+), 1 deletion(-)

Applied with a commit log and without the Python 2 variant (we no longer
add them).

>>From ff3e5c516f7cae4cff3037cde5d36d7f415727dd Mon Sep 17 00:00:00 2001
> From: Zheng Junjie <873216071@qq.com>
> Date: Thu, 21 Jan 2021 18:37:33 +0800
> Subject: [PATCH 2/2] gnu: Add xkeysnail.
>
> ---
>  gnu/packages/xdisorg.scm | 31 ++++++++++++++++++++++++++++++-
>  1 file changed, 30 insertions(+), 1 deletion(-)

[...]

> +    (propagated-inputs
> +     `(("python-six" ,python-six)
> +       ("python-appdirs" ,python-appdirs)
> +       ("python-evdev" ,python-evdev)
> +       ("python-inotify-simple" ,python-inotify-simple)
> +       ("python-xlib" ,python-xlib)))

Please use ‘wrap-script’ around the ‘xkeysnail’ executable instead of
propagating inputs.  That way, installing xkeysnail won’t “pollute” the
user profile with all these Python libraries.

> +    (license license:gpl3)))

Is it version-3-only or version-3-or-any-later-version?

Could you send an updated patch?

Thanks,
Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]