[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#46215] [PATCH] Add yadm
From: |
Leo Prikler |
Subject: |
[bug#46215] [PATCH] Add yadm |
Date: |
Sun, 31 Jan 2021 18:38:02 +0100 |
User-agent: |
Evolution 3.34.2 |
Hello Ellis,
Am Sonntag, den 31.01.2021, 16:47 +0000 schrieb Ellis Kenyo:
> ---
> gnu/packages/package-management.scm | 32
> +++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
Your commit is missing a ChangeLog in its message.
> [...]
> + (build-system gnu-build-system)
> + (arguments
> + '(#:tests? #f
Document why (i.e. "no check target").
> + #:make-flags (list (string-append "PREFIX=" (assoc-ref
> %outputs "out")))
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'bootstrap)
> + (delete 'configure)
> + (delete 'build))))
yadm has a few things you need to patch. For one, its shebang is
/bin/sh despite requiring bash. Also it contains a large number of
_PROGRAM variables, which would be need to be replaced by their actual
store path (use the which procedure for that).
> + (description "When you live in a command line, configurations
> are a deeply
> +personal thing. They are often crafted over years of experience,
> battles lost,
> +lessons learned, advice followed, and ingenuity rewarded. When you
> are away
> +from your own configurations, you are an orphaned refugee in
> unfamiliar and
> +hostile surroundings. You feel clumsy and out of sorts. You are
> filled with a
> +sense of longing to be back in a place you know. A place you built.
> A place
> +where all the short-cuts have been worn bare by your own travels. A
> place you
> +proudly call… $HOME.")
Nice advertisement, but not really a description. yadm.1 has a better
one, but keep to the formatting in Guix (particularly double spaces
after sentence end).
> + (license license:gpl3)))
Should be gpl3+.
Regards,
Leo