[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#46313] [PATCH] gnu: Add chiaki.
From: |
Nicolas Goaziou |
Subject: |
[bug#46313] [PATCH] gnu: Add chiaki. |
Date: |
Sun, 07 Feb 2021 10:43:41 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hello,
Léo Le Bouter via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/games.scm (chiaki): New variable.
Thank you. Some comments follow.
> + (recursive? #t)))
Do you know what sub-modules are being pulled? Could we unbundle them
instead?
> + (synopsis "Free and Open Source PlayStation Remote Play Client")
Please remove "Free" and "Open Source": everything is in Guix. Also,
synopsis should not use titlecase:
"PlayStation Remote Play client"
> + (description "Chiaki is a Free and Open Source Software Client for
> +PlayStation 4 and PlayStation 5 Remote Play.")
See above. Also, couldyou expound a bit the description?
> + (license
> + (license:fsdg-compatible
It should be fsf-free instead of fsdg-compatible.
> + "file://LICENSES/AGPL-3.0-only-OpenSSL.txt"
> + "AGPL-3.0-only-OpenSSL"))))
I think the correct string would be "AGPL-3.0 WITH OpenSSL exception"
but I wonder if Guix cares about the exception.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou