[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#43929] gnu: Add pijul.
From: |
Nicolas Goaziou |
Subject: |
[bug#43929] gnu: Add pijul. |
Date: |
Tue, 16 Feb 2021 10:31:41 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hello,
John Soo <jsoo1@asu.edu> writes:
Thank you. I'm adding my grain of salt, if you don't mind!
> +(define-public rust-trust-dns-rustls-0.6
> + (package
> + (inherit rust-trust-dns-rustls-0.7)
> + (name "rust-trust-dns-rustls")
AFAICT, rust-trust-dns-rustls-0.6 already inherits from 0.19, so it is
not strictly necessary to change this inheritance.
> +(define-public rust-yasna-0.1
> + (package
> + (name "rust-yasna")
> + (version "0.1.3")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (crate-uri "yasna" version))
> + (file-name
> + (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32
> + "1frcd79rzi6dlly7lldjn2avnhfmj6yxrjsgvb2p1k2zbxdzyc9s"))))
> + (build-system cargo-build-system)
> + (arguments
> + `(#:cargo-inputs
> + (("rust-bit-vec" ,rust-bit-vec-0.4)
> + ("rust-chrono" ,rust-chrono-0.4)
> + ("rust-num" ,rust-num-0.1)
> + ("rust-num-bigint" ,rust-num-bigint-0.1))
> + #:cargo-development-inputs
> + (("rust-num-traits" ,rust-num-traits-0.2))))
This should have #:skip-build #t as any non-leaf package.
> +(define-public rust-thrussh-keys-0.11
[...]
> + ("rust-thrussh-libsodium"
> + ,rust-thrussh-libsodium-0.1)
Nitpick: indentation.
> + ("rust-tokio" ,rust-tokio-0.1)
> + ("rust-yasna" ,rust-yasna-0.1))
> + #:cargo-development-inputs
> + (("rust-env-logger" ,rust-env-logger-0.6)
> + ("rust-tempdir" ,rust-tempdir-0.3)
> + ("rust-tokio-uds" ,rust-tokio-uds-0.2))))
See above about #:skip-build?
> + (home-page "https://pijul.org/thrussh")
> + (synopsis
> + "Deal with SSH keys in Rust")
> + (description
> + "This package provides a rust library to deal with SSH keys.
Nitpick: rust -> Rust
> + ("rust-thrussh-libsodium"
> + ,rust-thrussh-libsodium-0.1)
Indentation nitpick and #skip-build again :)
I will not repeat those in the rest of the message.
> + (synopsis
> + "Contains function definitions for the Windows API library advapi32")
s/Contains //
> + (description
> + "Contains function definitions for the Windows API library advapi32.
> +The winapi crate's types and constants has more details about this
> API.")
The description needs to be a complete sentence.
> + (synopsis
> + "Portably retrieve the username of the user running the current thread")
s/Portably //
> + (description
> + "Portably retrieve the user name (and possibly other information in
> +future versions) of the user running the current thread.")
Could you write it as a full sentence?
> +(define-public rust-spmc-0.2
> + (package
> + (inherit rust-spmc-0.3)
> + (name "rust-spmc")
> + (version "0.2.3")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (crate-uri "spmc" version))
> + (file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32 "1nhbjc65avbb4nffk6b49spbv7rsmmnrppj2qnx39mhwi57spgiw"))))
> + (arguments
> + `(#:tests? #f ;; tests hang
> + #:cargo-development-inputs
> + (("rust-loom" ,rust-loom-0.2))))
> + ;; This package is broken before 0.3
> + ;; Only included for pijul@1
> + (properties `((hidden? . #t)))))
I suggest to not bother and use #:skip-build?
> +(define-public rust-tokio-tls-0.1
> + (package
> + (inherit rust-tokio-tls-0.3)
> + (version "0.1.4")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (crate-uri "tokio-tls" version))
> + (file-name
> + (string-append
> + (package-name rust-tokio-tls-0.3) "-" version ".tar.gz"))
> + (sha256
> + (base32
> + "04yrdscn8m9qza8ms09pqipbmj6x2q64jgm5n3ipy4b0wl24nbvp"))))
> + (arguments
> + `(#:skip-build? #t
> + #:cargo-inputs
> + (("rust-futures" ,rust-futures-0.1)
> + ("rust-native-tls" ,rust-native-tls-0.1)
> + ("rust-tokio-core" ,rust-tokio-core-0.1)
> + ("rust-tokio-io" ,rust-tokio-io-0.1)
> + ("rust-tokio-proto" ,rust-tokio-proto-0.1))
> + #:cargo-development-inputs
> + (("rust-cfg-if" ,rust-cfg-if-0.1)
> + ("rust-env-logger" ,rust-env-logger-0.4)
> + ("rust-hyper" ,rust-hyper-0.11)
> + ("rust-openssl" ,rust-openssl-0.9)
> + ("rust-schannel" ,rust-schannel-0.1)
> + ("rust-security-framework"
> + ,rust-security-framework-0.1)
> + ("rust-tokio-service" ,rust-tokio-service-0.1)
> + ("rust-winapi" ,rust-winapi-0.3))))))
Since you use skip-build?, development inputs are not necessary.
> +(define-public pijul
> + (package
> + (name "pijul")
> + (version "0.12.2")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (crate-uri "pijul" version))
> + (file-name
> + (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32
> + "12aqpfd2si70qbvfnn9kvznxyd5g5gsb1kk1q52wm077cd03yapr"))))
> + (build-system cargo-build-system)
> + (inputs
> + `(("clang" ,clang)
> + ("libressl" ,libressl)
> + ("libsodium" ,libsodium)
> + ("nettle" ,nettle)
> + ("pkg-config" ,pkg-config)))
Shouldn't pgk-config and clang be native-inputs instead?
Regards,
--
Nicolas Goaziou