guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#46699] [PATCH] gnu: mumble: Update to 1.3.4.


From: Leo Prikler
Subject: [bug#46699] [PATCH] gnu: mumble: Update to 1.3.4.
Date: Mon, 22 Feb 2021 17:18:29 +0100
User-agent: Evolution 3.34.2

Hi jgart and all the others listening from LibreMiami,

Am Montag, den 22.02.2021, 00:59 +0000 schrieb jgart:
> Co-author: jgart <jgart@dismail.de>
> Co-author: Raghav Gururajan <rg@raghavgururajan.name>
IIRC, the correct tag would be Co-authored-by.

> * gnu/packages/telephony.scm (mumble): Update to 1.3.4.
This is not enough of a ChangeLog for the changes made here.

> -     `(#:tests? #f  ; no "check" target
> +     `(#:tests? #f                      ; no "check" target

> -                                           "no-oss" ; use pulse
> -                                           "no-alsa" ; use pulse
> +                                           "no-oss"       ; use
> pulse
> +                                           "no-alsa"      ; use
> pulse

> -              (with-output-to-file "scripts/mumble-overlay"
> -                (lambda ()
> -                  (format #t "#!~a~%" (which "bash"))
> -                  (format #t "export LD_PRELOAD=\"~a
> $LD_PRELOAD\"~%"
> -                          (string-append (assoc-ref outputs "out")
> -                                         "/lib/mumble/libmumble.so.1
> "))
> -                  (format #t "exec \"${@}\"")))
> -              #t))
> +             (with-output-to-file "scripts/mumble-overlay"
> +               (lambda ()
> +                 (format #t "#!~a~%" (which "bash"))
> +                 (format #t "export LD_PRELOAD=\"~a $LD_PRELOAD\"~%"
> +                         (string-append (assoc-ref outputs "out")
> +                                        "/lib/mumble/libmumble.so.1"
> ))
> +                 (format #t "exec \"${@}\"")))
> +             #t))

> -         (replace 'install ; install phase does not exist
> +         (replace 'install              ; install phase does not
> exist

> -       ("mesa" ,mesa) ; avoid bundled
> +       ("mesa" ,mesa)                   ; avoid bundled
>         ("openssl" ,openssl)
> -       ("opus" ,opus) ; avoid bundled
> +       ("opus" ,opus)                   ; avoid bundled

> -       ("speex" ,speex) ; avoid bundled
> -       ("speexdsp" ,speexdsp))) ; avoid bundled
> +       ("speex" ,speex)                 ; avoid bundled
> +       ("speexdsp" ,speexdsp)))         ; avoid bundled
These lines appear to be noise, some of them definitely are. 

> -     `(("pkg-config" ,pkg-config)
> -       ("python" ,python)
> -       ("qttools" ,qttools)))
> +     `(("perl" ,perl)
> +       ("pkg-config" ,pkg-config)
> +       ("python" ,python-wrapper)
> +       ("qttools" ,qttools)
> +       ("ruby" ,ruby)))
Are perl and ruby really required?  If so, what for?

Regards,
Leo






reply via email to

[Prev in Thread] Current Thread [Next in Thread]