[bug#47269] [PATCH 0/1] Add node-global-gradle-clean

[Dhruvin Gandhi]

> See ‘16.4 Packaging Guidelines’ and ‘16.6 Submitting Patches’ in the manual.

Yes, I will go through the guidelines first before submitting
next version of the patch with suggested changes.

> There's an uniform style for commit messages.  Example for
> when adding new packages:
> ...

I saw commit messages. I initially thought the committers added
them, as I did not know how the patches are applied. But now that
you have mentioned this, it makes sense, I will use that format
for commit messages.

> When defining a new package, usually a copyright line should
> be added at the top of the file.

Will do that.

> I prefer referring to the commit directly instead of by tag, as
> the commit is required for SWH fallback if the repo disappears.

Okay.

> Is there any particular reason tests are disabled?  Maybe add
> a comment "; No test suite." if that's the case.

Yes, there are no tests (as of 1.0.1). I will mention that.

> I'm not a fan of starting package descriptions with "This package is ...",
> even though plenty of plenty of packages in gnu/package/node-xyz.scm have
> such a description.  A description from gnu/packages/guile-xyz.scm I like:
> 
>      "Guile-DSV is a GNU Guile module for working with the
> delimiter-separated values (DSV) data format.  Guile-DSV supports the
> Unix-style DSV format and RFC 4180 format."

I borrowed synopsis and description from the global-gradle-clean package
author, and changed them a bit to match existing packages in the node-xyz
module. I agree that they can be more descriptive, and concise. I'll
update them as well.

I have a question. The package may be used by only a few users. I hope that
is okay with guix. Is there a rule defined somewhere, stating what gets in
this guix channel and what should not?

PS: When I submitted this patch, it created another bug 47270. I read about
what a patch series is and read about how to submit them to guix afterwards.
47270 may be closed in favor of 47269. I will follow the way specified in
guidelines.

Thanks Maxime for your suggestions.

Regards,
Dhruvin Gandhi